[scanner] "GError *" is not the same as "GError **"

Only set "throws" in the latter case

https://bugzilla.gnome.org/show_bug.cgi?id=602512

diff --git a/giscanner/glibtransformer.py b/giscanner/glibtransformer.py
index 158f8e8..d44987b 100644 (file)
--- a/giscanner/glibtransformer.py
+++ b/giscanner/glibtransformer.py
@@ -960,9 +960,9 @@ class GLibTransformer(object):
 
         last_param = func.parameters.pop()
 
-        if (last_param.type.name == 'GLib.Error' or
-            (self._namespace_name == 'GLib' and
-             last_param.type.name == 'Error')):
+        # Checking type.name=='GLib.Error' generates false positives
+        # on methods that take a 'GError *'
+        if last_param.type.ctype == 'GError**':
             func.throws = True
         else:
             func.parameters.append(last_param)