hide popup message if failure is handled - not sure what knock on effect this may...

[Pman.Core] / Pman.Request.js

diff --git a/Pman.Request.js b/Pman.Request.js
index b4db0f0..a2b5fc6 100644 (file)
--- a/Pman.Request.js
+++ b/Pman.Request.js
@@ -81,7 +81,7 @@ Roo.extend(Pman.Request, Roo.data.Connection, {
         }
         var res = this.processResponse(response);
                 
-        if (!res.success) { // error!
+        if (!res.success && !res.done) { // error!
             if (options.failure) {
                 // failure is handled... - do not show error..
                 Roo.callback(options.failure, options.scope, [res, options]);
@@ -94,6 +94,7 @@ Roo.extend(Pman.Request, Roo.data.Connection, {
         Roo.callback(options.success, options.scope, [res, options]);
         
     },
+    
     handleFailure : function(response, e){
         this.transId = false;
         var options = response.argument.options;
@@ -109,9 +110,12 @@ Roo.extend(Pman.Request, Roo.data.Connection, {
         if (res !== true) {
             var decode = this.processResponse(response);
             Roo.log(decode);
-            
-            if (Roo.MessageBox.isVisible()) {
-                alert(decode && decode.errorMsg ?  decode.errorMsg : "Error Sending data - return true from failure to remove message");
+            // this pops up even if we have a method to handle failure..
+            if (Roo.MessageBox.isVisible() ) {
+                if (!options.failure) {
+                    alert(decode && decode.errorMsg ?  decode.errorMsg : "Error Sending data - return true from failure to remove message");
+                }
+                
                 return;
             }