projects
/
Pman.Core
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
add caching to core_enum lookup
[Pman.Core]
/
DataObjects
/
Core_enum.php
diff --git
a/DataObjects/Core_enum.php
b/DataObjects/Core_enum.php
index
739134b
..
29ef576
100644
(file)
--- a/
DataObjects/Core_enum.php
+++ b/
DataObjects/Core_enum.php
@@
-254,6
+254,12
@@
class Pman_Core_DataObjects_Core_enum extends DB_DataObject
function lookupCreate($etype,$name, $display_name=false) {
function lookupCreate($etype,$name, $display_name=false) {
+ static $cache = array();
+ $ckey = json_encode(array($etype, $name));
+ if (isset($cache[$ckey])) {
+ return $cache[$ckey]->id;
+ }
+
// check
$ce = DB_DataObject::Factory('core_enum');
$ce->setFrom(array(
// check
$ce = DB_DataObject::Factory('core_enum');
$ce->setFrom(array(
@@
-269,11
+275,14
@@
class Pman_Core_DataObjects_Core_enum extends DB_DataObject
$ce->etype = $etype;
$ce->name = $name;
if ($ce->find(true)) {
$ce->etype = $etype;
$ce->name = $name;
if ($ce->find(true)) {
+ $cache[$ckey] = $ce->id;
return $ce->id;
}
$ce->active = 1;
$ce->display_name = $display_name === false ? $ce->name : $display_name;
return $ce->id;
}
$ce->active = 1;
$ce->display_name = $display_name === false ? $ce->name : $display_name;
- return $ce->insert();
+ $ret = $ce->insert();
+ $cache[$ckey] = $ret;
+ return $ret;
}
}