Prune.php

[Pman.Core] / Prune.php

diff --git a/Prune.php b/Prune.php
index c0a6c29..a29eac1 100644 (file)
--- a/Prune.php
+++ b/Prune.php
@@ -34,9 +34,9 @@ class Pman_Core_Prune extends Pman
         return false;
     }
     
-    function get($m="", $opts)
+    function get($m="", $opts=array())
     {
-        
+        echo "start?";
         // prune irrelivant stuff..
        
         
@@ -46,46 +46,38 @@ class Pman_Core_Prune extends Pman
     
     function prune($inM)
     {
-        // 40 seconds ? to delete 100K records..
-       // DB_DataObject::debugLevel(1);
-        $f = DB_DataObject::Factory('reader_article');
-        $f->query("
-            DELETE FROM Events where 
-                  event_when < NOW() - INTERVAL {$inM} MONTH
-                  LIMIT 100000
-        ");
         
-        // notificication events occur alot - so we should trash them more frequently..
-      /*  $f = DB_DataObject::Factory('reader_article');
-        $f->query("
-            DELETE FROM Events where 
-                  event_when < NOW() - INTERVAL 1 MONTH
-                  AND
-                  action IN ('NOTIFY')
-                  LIMIT 100000
-        ");
-        */
         // rather than deleting them all, it's probably best to just delete notify events that occured to often.
         // eg. when we tried to deliver multiple times without success...
+        /*
+         *
+         SELECT on_id, on_table, min(id) as min_id, max(id) as max_id, count(*) as mm FROM Events
+         WHERE action = 'NOTIFY' and event_when < NOW() - INTERVAL 1 WEEK GROUP BY  on_id, on_table HAVING  mm > 2 ORDER BY mm desc;
+         */
         
-        
+        DB_DataObject::debugLevel(1);
         $f = DB_DataObject::Factory('Events');
         $f->selectAdd();
-        $f->selectAdd("on_id, min(id) as min_id, max(id) as max_id, count(*) as mm");
+        $f->selectAdd("on_id, on_table, min(id) as min_id, max(id) as max_id, count(*) as mm");
         $f->whereAdd("action = 'NOTIFY' and event_when < NOW() - INTERVAL 1 WEEK");
-        $f->groupBy('on_id');
+        $f->groupBy('on_id, on_table');
         $f->having("mm > 2");
         $f->orderBy('mm desc') ;
-        $f->limit(1000);
+        $f->limit(10000);
+        exit;
         $ar = $f->fetchAll();
         foreach($ar as $f) {
-            $f = DB_DataObject::Factory('Events');
-            $f->query("DELETE FROM Events where 
+            $q = DB_DataObject::Factory('Events');
+            $q->query("DELETE FROM Events where 
                   action = 'NOTIFY'
                   AND
                   on_id = {$f->on_id}
                   AND
-                  id > {$f->min_id} AND id < {$f->max_id}
+                  on_table = '{$q->escape($f->on_table)}'
+                  AND
+                  id > {$f->min_id}
+                  AND
+                  id < {$f->max_id}
             ");
         }