MTrack/CommitChecker.php

[web.mtrack] / MTrack / CommitChecker.php

diff --git a/MTrack/CommitChecker.php b/MTrack/CommitChecker.php
index e5746b4..39ba3b9 100644 (file)
--- a/MTrack/CommitChecker.php
+++ b/MTrack/CommitChecker.php
@@ -32,6 +32,7 @@ class MTrack_CommitChecker {
     var $authUser;
     
     var $checks = array();
+    
     function __construct($ar) {
         foreach($ar as $k=>$v) {
             $this->$k = $v;
@@ -42,6 +43,7 @@ class MTrack_CommitChecker {
         
         
     }
+    
 
     function checkVeto()
     {
@@ -190,11 +192,12 @@ class MTrack_CommitChecker {
         } else {
             require_once 'MTrack/CommitHookChangeEvent.php';
             $c = new MTrackCommitHookChangeEvent;
-            $c->rev = $bridge->getChangesetDescriptor();
-            $c->changelog = $bridge->getCommitMessage();
-            $c->changeby = $this->authUser->email; //???
+            $c->rev         = $bridge->getChangesetDescriptor();
+            $c->changelog   = $bridge->getCommitMessage();
+            $c->changeby    = $this->authUser->email; //???
             $c->changeby_id = $this->authUser->id; //???
-            $c->ctime = time();
+            $c->ctime       = time();
+            $c->fileActions = $bridge->fileActions;
             $changes[] = $c;
         }
         return $changes;
@@ -202,6 +205,14 @@ class MTrack_CommitChecker {
 
     function postCommit(IMTrackCommitHookBridge $bridge)
     {
+       
+        // this might be run on multiple commits (big push...)
+        
+        
+        // in our system, we not only log commits that are against a
+        // ticket, but also ones that are not..
+        
+        
         $files = $bridge->enumChangedOrModifiedFileNames();
         
         $fqfiles = array();
@@ -211,6 +222,10 @@ class MTrack_CommitChecker {
 
         // build up overall picture of what needs to be applied to tickets
         $changes = $this->_getChanges($bridge);
+        
+        
+        print_R($changes);
+        
 
         // Deferred by tid
         $deferred = array();
@@ -226,6 +241,9 @@ class MTrack_CommitChecker {
         
         $me = $this->authUser;
 
+
+
+
         foreach ($changes as $c) {
             $tickets = array();
             $log = $c->changelog;
@@ -241,13 +259,16 @@ class MTrack_CommitChecker {
             }
             if (count($tickets) == 0) {
                 $no_ticket[] = $c;
+                
                 continue;
             }
             
             // apply changes to tickets
             foreach ($tickets as $tkt => $act) {
                 // removed all the code that handles hashed ticked ids...
-                $T = clone($this->ticketProvider);
+                
+                $T = DB_DataObject::Factory('mtrack_ticket');
+                
                 if (!$T->get($tkt)) {
                     continue;
                 }
@@ -293,25 +314,38 @@ class MTrack_CommitChecker {
                   $log .= " (on behalf of [user:$c->changeby]) ";
                 }
                 */
+                
             
             $log .= $c->changelog;
+            if (!isset($deferred[$T->id])) {
+                $deferred[$T->id] = array(
+                    'comments' => array(),
+                    'changes' => array(),
+                    'act' => array(),
+                    
+                );
+            }
+            
             
             $deferred[$T->id]['comments'][] = $log;
+            $deferred[$T->id]['changes'][] = $c;
+            $deferred[$T->id]['ticket'] = $T;
+            
             
             if (isset($act['spent']) && $c->changeby != $me) {
                 $spent_by_tid_by_user[$T->id][$c->changeby_id][] = $act['spent'];
                 unset($act['spent']);
             }
-            $deferred[$T->tid]['act'][] = $act;
-
-        
+            $deferred[$T->id]['act'][] = $act;
+ 
             //??? 
             $this->checkVeto('postCommit', $log, $fqfiles, $actions);
         }
         
-        // defered is a list of actions...
         
-        $this->defered = $defered;
+        // defered is a list of actions...
+        $this->no_ticket = $no_ticket;
+        $this->deferred = $deferred;
         $this->spent_by_tid_by_user = $spent_by_tid_by_user;