Fix #8044 - fixing varous crashes, correct tree drop location and empty nodes after...

[roobuilder] / src / Builder4 / WindowLeftProps.bjs

diff --git a/src/Builder4/WindowLeftProps.bjs b/src/Builder4/WindowLeftProps.bjs
index 7df8fe4..683a988 100644 (file)
--- a/src/Builder4/WindowLeftProps.bjs
+++ b/src/Builder4/WindowLeftProps.bjs
@@ -795,7 +795,9 @@
              " var lb = (Gtk.Label) ((Gtk.ListItem)listitem).get_child();",
              " var item = (JsRender.NodeProp) ((Gtk.ListItem)listitem).get_item();",
              "",
-             "",
+             " if (item == null) {",
+             " \treturn;",
+             "}",
              "item.bind_property(\"to_display_name_prop\",",
              "                    lb, \"label\",",
              "                   GLib.BindingFlags.SYNC_CREATE);",
@@ -869,6 +871,15 @@
              "\tcb.hide();",
              "\t",
              "\tvar prop = (JsRender.NodeProp) ((Gtk.ListItem)listitem).get_item();",
+             " \tif (prop == null || _this.node == null ) {",
+             " \t\tGLib.error(\"something is wrong\");",
+             "\t \treturn;",
+             "\t}",
+             "\tif ( _this.node.fqn() == \"\") {",
+             " \t\tGLib.debug(\"node is missing fqn\");",
+             "\t \treturn;",
+             "\t}",
+             "\t",
              "\t//GLib.debug(\"prop = %s\", prop.get_type().name());",
              "\t//GLib.debug(\"prop.val = %s\", prop.val);",
              "\t//GLib.debug(\"prop.key = %s\", prop.to_display_name());",
@@ -1244,6 +1255,9 @@
         "\t\t}",
         "\t\tif (l.get_visible()) {",
         "\t\t \t_this.stop_editor();",
+        "\t\t \tif (prop.parent == null) {",
+        "\t\t \t\treturn;",
+        "\t \t\t}",
         "\t    \t_this.show_editor(_this.file, prop.parent, prop);",
         "\t\t",
         "\t\t}",
@@ -1417,7 +1431,7 @@
     "    \t",
     "    }",
     "    ",
-    "    GLib.debug(\"load leftprops\\n\");",
+    "    GLib.debug(\"load leftprops\");",
     "",
     "    this.node = node;",
     "    this.file = file;",
@@ -1427,6 +1441,7 @@
     "              ",
     "    //this.get('/RightEditor').el.hide();",
     "    if (node ==null) {",
+    "        GLib.debug(\"node is null return\");",
     "        return ;",
     "    }",
     "",