From fca4046e3312bf911c00792c2839c478073c9703 Mon Sep 17 00:00:00 2001
From: Alan Knowles <alan@roojs.com>
Date: Mon, 17 Dec 2018 10:01:29 +0800
Subject: [PATCH] Changed NewBranch.bjsNewBranch.vala

---
 NewBranch.bjs  | 16 ++++++++--------
 NewBranch.vala |  3 ++-
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/NewBranch.bjs b/NewBranch.bjs
index 040ffc1d..18a6cd0b 100644
--- a/NewBranch.bjs
+++ b/NewBranch.bjs
@@ -65,8 +65,8 @@
           "changed" : "() => {\n\tif (this.loading) {\n\t\treturn;\n\t}\n\tvar project_id = this.selectedProjectId();\n\t_this.dbmodel.loadTickets(project_id);\n\t\n\t\n\t/*if (this.loading) {\n\t\treturn;\n\t}\n\tvar ticket_id = this.selectedTicketId();\n\t\n\tvar name = RooTicket.singleton().usernameLocal();\n\t\n\tif (ticket_id == \"\" || ticket_id == null) {\n\t\n\t\tvar dt = new  DateTime.now_local();\n\t\t_this.name.el.set_text(\"wip_%s_%s\".printf(name,dt.format(\"%Y_%b_%d\")));\n\t\treturn;\n\t}\n\t\n\t\n\tvar ticket = RooTicket.singleton().getById(ticket_id);\n   \n\t_this.name.el.set_text(\"wip_%s_T%s_%s\".printf(name,ticket.id, ticket.summaryToBranchName()));\n\t\n\t//GLib.debug (//\"Selection: %s, %s\\n\", (string) val1, (string) val2);\n\t*/\n}"
          },
          "* ctor" : "new Gtk.ComboBox.with_entry()",
-         "id" : "projectsel",
          "| string selectedProjectId" : "() {\n\tGtk.TreeIter iter;\n\tValue val1;\n \n \n\tthis.el.get_active_iter (out iter);\n\t_this.prmodel.el.get_value (iter, 0, out val1);\n \n\n\treturn  (string) val1;\n\t\n\t\n\t\n\t\n}\n",
+         "id" : "projectsel",
          "* init" : "this.el.set_entry_text_column(1);",
          "* pack" : "attach_defaults,0,1,1,2",
          "xtype" : "ComboBox",
@@ -75,8 +75,8 @@
          "items" : [
           {
            "id" : "prcellrenderer",
-           "xtype" : "CellRendererText",
            "* pack" : "pack_start,true",
+           "xtype" : "CellRendererText",
            "$ xns" : "Gtk"
           },
           {
@@ -105,14 +105,14 @@
          "items" : [
           {
            "id" : "dbcellrenderer",
-           "* pack" : "pack_start,true",
            "xtype" : "CellRendererText",
+           "* pack" : "pack_start,true",
            "$ xns" : "Gtk"
           },
           {
            "id" : "dbmodel",
-           "* pack" : "set_model",
            "xtype" : "ListStore",
+           "* pack" : "set_model",
            "| void loadTickets" : "(string project_id) {\n\n\n    \n    // fixme .. get project id from selection..\n    \n     RooTicket.singleton().loadTickets(\n \t\t\tproject_id,\n \t\t\t_this.btn_not_me.el.active ? RooTicket.NotMe.TRUE :  RooTicket.NotMe.FALSE,\n \t\t\t _this.btn_closed.el.active ? RooTicket.Closed.TRUE :  RooTicket.Closed.FALSE\n\t\t );\n        \n    _this.ticketsel.loading = true;\n\n    this.el.clear();                                    \n    Gtk.TreeIter iter;\n    var el = this.el;\n    \n    el.append(out iter);\n\n    \n    el.set_value(iter, 0, \"\");\n    el.set_value(iter, 1, \"-- select a ticket --\");\n    \n    _this.ticketsel.el.set_active_iter(iter);\n    var tickets = RooTicket.singleton().tickets;\n    foreach(var ticket in tickets) {\n    \n        el.append(out iter);\n        \n        el.set_value(iter, 0, ticket.id);\n        el.set_value(iter, 1, \"#%s [%s] %s\".printf( ticket.id, ticket.project_id_name , ticket.summary));\n        \n        //if (data.get(i) == cur) {\n         //   _this.build_module.el.set_active_iter(iter);\n       // }\n        \n    }\n    \n    _this.ticketsel.loading = false;\n     //this.el.set_sort_column_id(0, Gtk.SortType.ASCENDING);          \n                                     \n}\n",
            "$ columns" : "typeof(string),typeof(string)",
            "n_columns" : 2,
@@ -122,8 +122,8 @@
         },
         {
          "bool expand" : false,
-         "xtype" : "Button",
          "* pack" : "attach_defaults,4,5,1,2",
+         "xtype" : "Button",
          "string label" : "New Ticket",
          "$ xns" : "Gtk"
         },
@@ -146,7 +146,7 @@
         },
         {
          "listeners" : {
-          "activate" : "() => {\n\t_this.el.response(1);\n}\n"
+          "clicked" : "() => {\n\tGLib.debug(\"fire response = 1\");\n\t_this.el.response(1);\n}"
          },
          "label" : "Create Branch",
          "* init" : "{\n   this.el.get_style_context().add_class(\"suggested-action\");\n}\n",
@@ -165,8 +165,8 @@
             "toggled" : "() => {\n\tvar project_id = _this.projectsel.selectedProjectId();\n\t_this.dbmodel.loadTickets(project_id);\t\n}"
            },
            "id" : "btn_not_me",
-           "string label" : "Show tickets not assigned to me",
            "* pack" : "add",
+           "string label" : "Show tickets not assigned to me",
            "xtype" : "CheckButton",
            "$ xns" : "Gtk"
           },
@@ -175,8 +175,8 @@
             "toggled" : "() => {\n \tvar project_id = _this.projectsel.selectedProjectId();\n\t_this.dbmodel.loadTickets(project_id);\t\n\t \n}"
            },
            "id" : "btn_closed",
-           "xtype" : "CheckButton",
            "string label" : "Show closed Tickets",
+           "xtype" : "CheckButton",
            "* pack" : "add",
            "$ xns" : "Gtk"
           },
diff --git a/NewBranch.vala b/NewBranch.vala
index 34662cd4..86fc32ac 100644
--- a/NewBranch.vala
+++ b/NewBranch.vala
@@ -681,7 +681,8 @@ public class NewBranch : Object
             }
 
             //listeners
-            this.el.activate.connect( () => {
+            this.el.clicked.connect( () => {
+            	GLib.debug("fire response = 1");
             	_this.el.response(1);
             });
         }
-- 
2.39.2