Spawn.vala
[gitlive] / Spawn.vala
index f2b683f..c9e67f5 100644 (file)
@@ -60,7 +60,7 @@ static int main (string[] args) {
 public delegate void SpawnOutput(string line);
 public delegate void SpawnErr(string line);
 public delegate string SpawnInput();
-public delegate void SpawnFinish(int result);
+public delegate void SpawnFinish(int result, string output);
  
 
 public class  SpawnConfig {
@@ -74,7 +74,7 @@ public class  SpawnConfig {
     public SpawnOutput output;
     public SpawnErr stderr;
     public SpawnInput input;
-    public SpawnFinish finish;
     // defaults..
     public SpawnConfig(string cwd,
             string[] args,
@@ -85,7 +85,7 @@ public class  SpawnConfig {
         this.env = env;
          
         async = false;
-        exceptions = false;
+        exceptions = true;
         debug = false;
         
         output = null;
@@ -94,25 +94,21 @@ public class  SpawnConfig {
         
     }
     
-    public void setOptions(
-            bool async,
-            bool exceptions,
-            bool debug
-        ) {
-        this.async = async;
-        this.exceptions = exceptions;
-        this.debug = debug;
+    public void onFinish( SpawnFinish? finish ) {
+               this.finish = finish;
     }
+
     public void setHandlers(
             SpawnOutput? output,
             SpawnErr? stderr,
-            SpawnInput? input,
-            SpawnFinish? finish
+            SpawnInput? input 
          ) {
         this.output = output;
         this.stderr = stderr;
         this.input = input;
-        this.finish = finish;
+        
     }
     
     
@@ -153,13 +149,14 @@ public class Spawn : Object
        
      
         this.cfg = cfg;
-     
+        this.output = "";
+        this.stderr = "";
     
         this.cfg.cwd =  this.cfg.cwd.length  < 1 ? GLib.Environment.get_home_dir() : this.cfg.cwd;
         if (this.cfg.args.length < 0) {
             throw new SpawnError.NO_ARGS("No arguments");
         }
-        this.run();
+        this.run((res, output) => { });
     
     }
 
@@ -169,11 +166,11 @@ public class Spawn : Object
     /**
      * @property output {String} resulting output
      */
-    string output  = "";
+    public string output;
     /**
      * @property stderr {String} resulting output from stderr
      */
-    string stderr  = "";
+    public string stderr;
      /**
      * @property result {Number} execution result.
      */
@@ -211,7 +208,7 @@ public class Spawn : Object
      * result is applied to object properties (eg. '?' or 'stderr')
      * @returns {Object} self.
      */
-    public void run() throws SpawnError, GLib.SpawnError, GLib.IOChannelError
+    public void run(unowned SpawnFinish? finished_cb) throws SpawnError, GLib.SpawnError, GLib.IOChannelError
     {
         
          
@@ -224,7 +221,7 @@ public class Spawn : Object
 
         
         if (this.cfg.debug) {
-           stdout.printf("cd %s; %s" , this.cfg.cwd , string.joinv(" ", this.cfg.args));
+           stdout.printf("cd %s; %s\n" , this.cfg.cwd , string.joinv(" ", this.cfg.args));
         }
         
         Process.spawn_async_with_pipes (
@@ -236,7 +233,7 @@ public class Spawn : Object
                 out this.pid,
                 out standard_input,
                 out standard_output,
-                       out standard_error);
+                           out standard_error);
 
                // stdout:
        
@@ -245,14 +242,33 @@ public class Spawn : Object
          
         if (this.cfg.debug) {
             
-            stdout.printf("PID: %d" ,this.pid);
+            stdout.printf("PID: %d\n" ,this.pid);
         }
-         
+        
+        this.ref(); // additional ref - cleared on tidyup...
+        
+        this.in_ch = new GLib.IOChannel.unix_new(standard_input);
+        this.out_ch = new GLib.IOChannel.unix_new(standard_output);
+        this.err_ch = new GLib.IOChannel.unix_new(standard_error);
+        
+        // make everything non-blocking!
+        
+        
+            
+        // using NONBLOCKING only works if io_add_watch
+          //returns true/false in right conditions
+          this.in_ch.set_flags (GLib.IOFlags.NONBLOCK);
+          this.out_ch.set_flags (GLib.IOFlags.NONBLOCK);
+          this.err_ch.set_flags (GLib.IOFlags.NONBLOCK);
+                   
+      
+
         ChildWatch.add (this.pid, (w_pid, result) => {
            
             this.result = result;
             if (this.cfg.debug) {
-                stdout.printf("child_watch_add : result:%d ", result);
+                stdout.printf("child_watch_add : result:%d\n", result);
             }
            
             this.read(this.out_ch);
@@ -275,34 +291,22 @@ public class Spawn : Object
                          
         
         
-        this.in_ch = new GLib.IOChannel.unix_new(standard_input);
-        this.out_ch = new GLib.IOChannel.unix_new(standard_output);
-        this.err_ch = new GLib.IOChannel.unix_new(standard_error);
-        
-        // make everything non-blocking!
-        
-        
-            
-                  // using NONBLOCKING only works if io_add_watch
-          //returns true/false in right conditions
-          this.in_ch.set_flags (GLib.IOFlags.NONBLOCK);
-          this.out_ch.set_flags (GLib.IOFlags.NONBLOCK);
-          this.err_ch.set_flags (GLib.IOFlags.NONBLOCK);
-                   
-      
+       
             
             // add handlers for output and stderr.
         
         this.out_src = (int) this.out_ch.add_watch (
             IOCondition.OUT | IOCondition.IN  | IOCondition.PRI |  IOCondition.HUP |  IOCondition.ERR  ,
             (channel, condition) => {
-               return this.read(this.out_ch);
+                return this.read(channel);
+                //return this.out_ch != null ? this.read(this.out_ch) : true;
             }
         );
         this.err_src = (int) this.err_ch.add_watch (
-           IOCondition.OUT | IOCondition.IN  | IOCondition.PRI |  IOCondition.HUP |  IOCondition.ERR  ,
+                IOCondition.OUT | IOCondition.IN  | IOCondition.PRI |  IOCondition.HUP |  IOCondition.ERR  ,
             (channel, condition) => {
-               return this.read(this.err_ch);
+               return this.read(channel);
+               //return this.err_ch != null ? this.read(this.err_ch)  : true;
             }
         );
               
@@ -338,9 +342,10 @@ public class Spawn : Object
         // start mainloop if not async..
         
         if (this.pid > -1) {
-            if (this.cfg.debug) {
-                print("starting main loop");
-            }
+             //print("starting main loop");
+             //if (this.cfg.debug) {
+             //  
+             // }
                this.ctx = new MainLoop ();
             this.ctx.run(); // wait fore exit?
             
@@ -349,23 +354,25 @@ public class Spawn : Object
             this.tidyup(); // tidyup get's called in main loop. 
         }
         
+        
         if (this.cfg.exceptions && this.result != 0) {
-           
-            throw new SpawnError.EXECUTE_ERROR(this.stderr);
+                       var errstr = string.joinv(" ", this.cfg.args) + "\n";
+                       errstr += this.output;
+                       errstr += this.output.length > 0 ? "\n" : "";
+                       errstr += this.stderr;
+                       //print("Throwing execute error:%s\n", errstr);
+            throw new SpawnError.EXECUTE_ERROR(errstr);
             //this.toString = function() { return this.stderr; };
             ///throw new Exception this; // we throw self...
         }
-        
         // finally throw, or return self..
-        
         return;
     
     }
-    
-    
 
     private void tidyup()
     {
+        //print("Tidyup\n"); 
         if (this.pid > -1) {
             Process.close_pid(this.pid); // hopefully kills it..
             this.pid = -1;
@@ -375,7 +382,7 @@ public class Spawn : Object
             if (this.out_ch != null)  this.out_ch.shutdown(true);
             if (this.err_ch != null)  this.err_ch.shutdown(true);
         } catch (Error e) {
-            // error shutting donw.
+            // error shutting down
         }
         // blank out channels
         this.in_ch = null;
@@ -386,7 +393,7 @@ public class Spawn : Object
         //if (this.out_src > -1 ) GLib.source_remove(this.out_src);
         this.err_src = -1;
         this.out_src = -1;
-        
+        this.unref();
     }
     
     
@@ -415,6 +422,7 @@ public class Spawn : Object
         return str.length;
         
     }
     
     /**
      * read from pipe and call appropriate listerner and add to output or stderr string.
@@ -425,7 +433,7 @@ public class Spawn : Object
     {
         string prop = (ch == this.out_ch) ? "output" : "stderr";
        // print("prop: " + prop);
-
+        //print ("spawn.read: %s\n", prop);
         
         //print(JSON.stringify(ch, null,4));
         while (true) {
@@ -433,14 +441,29 @@ public class Spawn : Object
             size_t term_pos;
             size_t len;
             IOStatus status;
+            
+            if (this.pid < 0) {
+                return false; // spawn complete + closed... can't read any more.
+            }
+            
             try {
+                               var cond = ch.get_buffer_condition();
+                               //if ((cond & GLib.IOCondition.ERR) > 0) {
+                               //      return false;
+                               //}
+                               //if ((cond & GLib.IOCondition.IN) < 1) {
+                               //      return false;
+                               //}
                 status = ch.read_line( out buffer,  out len,  out term_pos );
             } catch (Error e) {
                 //FIXme
-                break; // ??
+               return false;
                 
             }
-
+            if (buffer == null) {
+                       return false;
+               }
+            //print("got buffer of %s\n", buffer);
             // print('status: '  +JSON.stringify(status));
             // print(JSON.stringify(x));
              switch(status) {
@@ -453,20 +476,21 @@ public class Spawn : Object
                     //}
                     if (ch == this.out_ch) {
                         this.output += buffer;
-                        this.cfg.output(  buffer);                  
+                        if (this.cfg.output != null) {
+                                this.cfg.output(  buffer);                  
+                        }
                     } else {
                         this.stderr += buffer;
                     }
                     //_this[prop] += x.str_return;
-                    if (this.cfg.debug) {
-                        stdout.printf("%s : %s", prop , buffer);
-                    }
+                    //if (this.cfg.debug) {
+                       // stdout.printf("%s : %s", prop , buffer);
+                    //}
                     if (this.cfg.async) {
                          
                         if ( Gtk.events_pending()) {
                              Gtk.main_iteration();
                         }
-                         
                     }
                     
                     //this.ctx.iteration(true);