From de203388ca0b5f0c13912316371c527a340ddbb8 Mon Sep 17 00:00:00 2001
From: Edward <edward@roojs.com>
Date: Fri, 12 Oct 2018 11:02:22 +0800
Subject: [PATCH] DataObjects/Images.php

---
 DataObjects/Images.php | 70 ++++++++++++++++++++++--------------------
 1 file changed, 37 insertions(+), 33 deletions(-)

diff --git a/DataObjects/Images.php b/DataObjects/Images.php
index 4c1b9284..82f3a9a7 100644
--- a/DataObjects/Images.php
+++ b/DataObjects/Images.php
@@ -830,40 +830,44 @@ class Pman_Core_DataObjects_Images extends DB_DataObject
         
         $data = file_get_contents($file);
         
+//        if(!empty($scaleWidth) || !empty($scaleHeight)){
+//            
+//            $width = $this->width;
+//            $height = $this->height;
+//            
+//            if(!empty($scaleWidth)){
+//                $width = $scaleWidth;
+//
+//                if(empty($scaleHeight)){
+//                    $height = $this->height * $scaleWidth / $this->width;
+//                }
+//            }
+//            
+//            
+//
+//            if(!empty($scaleHeight)){
+//                $height = $scaleHeight;
+//
+//                if(empty($scaleWidth)){
+//                    $width = $this->width * $scaleHeight / $this->height;
+//                }
+//            }
+//            
+//            $im = imagecreatefromstring($data);
+//            
+//            if (($scaled = imagescale($im, $width, $height)) != false) {
+//                ob_start();
+//                imagejpeg($scaled);
+//                $data = ob_get_contents();
+//                ob_end_clean();
+//                imagedestroy($im);
+//                imagedestroy($scaled);
+//            }
+//            
+//        }
+        
         if(!empty($scaleWidth) || !empty($scaleHeight)){
-            
-            $width = $this->width;
-            $height = $this->height;
-            
-            if(!empty($scaleWidth)){
-                $width = $scaleWidth;
-
-                if(empty($scaleHeight)){
-                    $height = $this->height * $scaleWidth / $this->width;
-                }
-            }
-            
-            
-
-            if(!empty($scaleHeight)){
-                $height = $scaleHeight;
-
-                if(empty($scaleWidth)){
-                    $width = $this->width * $scaleHeight / $this->height;
-                }
-            }
-            
-            $im = imagecreatefromstring($data);
-            
-            if (($scaled = imagescale($im, $width, $height)) != false) {
-                ob_start();
-                imagejpeg($scaled);
-                $data = ob_get_contents();
-                ob_end_clean();
-                imagedestroy($im);
-                imagedestroy($scaled);
-            }
-            
+            $data = $this->scale($scaleWidth, $scaleHeight);
         }
         
         if($rotate){
-- 
2.39.2