From: Alan <alan@roojs.com>
Date: Thu, 15 Feb 2024 03:13:34 +0000 (+0800)
Subject: extra numberic checks as we are using 100%
X-Git-Url: http://git.roojs.org/?p=Pman.Core;a=commitdiff_plain;h=cfaf0c6197bdb90225d1d2f42196ca21cdfe34f2

extra numberic checks as we are using 100%
---

diff --git a/Images.php b/Images.php
index 62d760c6..bcedb003 100644
--- a/Images.php
+++ b/Images.php
@@ -505,15 +505,15 @@ class Pman_Core_Images extends Pman
         }
         
         $w =  is_string($dom) ? false : $dom->getAttribute('width');
-        $h =  is_string($dom) ? false : $dom->getAttribute('width');
+        $h =  is_string($dom) ? false : $dom->getAttribute('height');
         
-        if (!is_string($dom) && (!empty($w) || !empty($h)) )
+        if (!is_string($dom) && (!empty($w) || !empty($h) ) && is_numeric($w) && is_numeric($h))
         {
             // no support for %...
             $thumbsize =
-                (empty($w) ? '0' : $w * 1) .
+                (empty($w) ? '0' : intval($w) * 1) .
                 'x' .
-                (empty($h) ? '0' : $h * 1);
+                (empty($h) ? '0' : intval($h) * 1);
              $provider = '/Images/Thumb';
             
         }