From: Alan Knowles <alan@roojs.com>
Date: Fri, 11 Sep 2020 08:02:03 +0000 (+0800)
Subject: handle empty companies
X-Git-Url: http://git.roojs.org/?p=Pman.Core;a=commitdiff_plain;h=c8c28ad4fd428d676f271af4142af913d47f755a

handle empty companies
---

diff --git a/DataObjects/Core_email.php b/DataObjects/Core_email.php
index 34d2591b..03b90721 100644
--- a/DataObjects/Core_email.php
+++ b/DataObjects/Core_email.php
@@ -363,7 +363,8 @@ class Pman_Core_DataObjects_Core_email extends DB_DataObject
         
         if (!empty($this->bcc_group_id) && $this->bcc_group_id > 0 && empty($contents['bcc']) && empty($contents['rcpts_group'])) {
             $admin_grp = DB_DAtaObject::Factory('core_group')->load($this->bcc_group_id);
-	    $admin = $admin_grp->members('email');
+	    
+	    $admin = $admin_grp ?  $admin_grp->members('email') : false;
             
             if (empty($admin) && $admin_grp->name != 'Empty Group') { // allow 'empty group mname'
                 return $p->raiseError("template [{$contents['template']}] - bcc group is empty");
diff --git a/DataObjects/Core_person.php b/DataObjects/Core_person.php
index 30b72af7..5160b4e3 100644
--- a/DataObjects/Core_person.php
+++ b/DataObjects/Core_person.php
@@ -602,6 +602,9 @@ class Pman_Core_DataObjects_Core_person extends DB_DataObject
     
     function company()
     {
+        if (empty($this->company_id)) {
+            return false;
+        }
         $x = DB_DataObject::factory('core_company');
         $x->autoJoin();
         $x->get($this->company_id);
@@ -1160,7 +1163,7 @@ class Pman_Core_DataObjects_Core_person extends DB_DataObject
     
     function setFromRoo($ar, $roo)
     {
-        $this->setFrom($ar);
+        $this->setFrom($ar); 
         
         if(!empty($ar['_enable_oath_key'])){
             $oath_key = $this->generateOathKey();
@@ -1181,7 +1184,7 @@ class Pman_Core_DataObjects_Core_person extends DB_DataObject
         }
         // this only applies to our owner company..
         $c = $this->company();
-        if (empty($c->comptype_name) || $c->comptype_name != 'OWNER') {
+        if (empty($c) || empty($c->comptype_name) || $c->comptype_name != 'OWNER') {
             return true;
         }