From: Alan Knowles <alan@roojs.com>
Date: Fri, 11 Sep 2020 02:13:31 +0000 (+0800)
Subject: hide popup message if failure is handled - not sure what knock on effect this may... 
X-Git-Url: http://git.roojs.org/?p=Pman.Core;a=commitdiff_plain;h=586e4eb470252d837ba18b67e4c3c1702131fd1d

hide popup message if failure is handled - not sure what knock on effect this may have...
---

diff --git a/Pman.Request.js b/Pman.Request.js
index 82d18ff0..a2b5fc6c 100644
--- a/Pman.Request.js
+++ b/Pman.Request.js
@@ -94,6 +94,7 @@ Roo.extend(Pman.Request, Roo.data.Connection, {
         Roo.callback(options.success, options.scope, [res, options]);
         
     },
+    
     handleFailure : function(response, e){
         this.transId = false;
         var options = response.argument.options;
@@ -109,9 +110,12 @@ Roo.extend(Pman.Request, Roo.data.Connection, {
         if (res !== true) {
             var decode = this.processResponse(response);
             Roo.log(decode);
-            
-            if (Roo.MessageBox.isVisible()) {
-                alert(decode && decode.errorMsg ?  decode.errorMsg : "Error Sending data - return true from failure to remove message");
+            // this pops up even if we have a method to handle failure..
+            if (Roo.MessageBox.isVisible() ) {
+                if (!options.failure) {
+                    alert(decode && decode.errorMsg ?  decode.errorMsg : "Error Sending data - return true from failure to remove message");
+                }
+                
                 return;
             }