From: Alan Knowles <alan@roojs.com>
Date: Wed, 4 Sep 2019 02:47:13 +0000 (+0800)
Subject: Fix #6027 - group memberships on users list
X-Git-Url: http://git.roojs.org/?p=Pman.Core;a=commitdiff_plain;h=2be150527d6ada3cea26eba761c642ce1f056ad4

Fix #6027 - group memberships on users list
---

diff --git a/DataObjects/Core_person.php b/DataObjects/Core_person.php
index 1e30d4ad..740fb549 100644
--- a/DataObjects/Core_person.php
+++ b/DataObjects/Core_person.php
@@ -1143,22 +1143,21 @@ class Pman_Core_DataObjects_Core_person extends DB_DataObject
     function selectAddGroupMemberships()
     {
         $this->selectAdd("
-            CONCAT ('[',
-                COALESCE((
-                    SELECT
-                        GROUP_CONCAT( 
-                            JSON_QUOTE(core_group.name)
-                        )
-                    FROM
-                        core_group_member
-                    LEFT JOIN
-                        core_group
-                    ON
-                        core_group.id = core_group_member.group_id
-                    WHERE
-                        core_group_member.user_id = core_person.id
-                ), ''),
-            ']') as member_of_json");
+            
+            COALESCE((
+                SELECT
+                    GROUP_CONCAT( 
+                        core_group.name
+                    , '\n')
+                FROM
+                    core_group_member
+                LEFT JOIN
+                    core_group
+                ON
+                    core_group.id = core_group_member.group_id
+                WHERE
+                    core_group_member.user_id = core_person.id
+            ), '')  as member_of");
     }
     
     function setFromRoo($ar, $roo)
diff --git a/Pman.Tab.PersonList.js b/Pman.Tab.PersonList.js
index fcd47cd4..9da9e679 100644
--- a/Pman.Tab.PersonList.js
+++ b/Pman.Tab.PersonList.js
@@ -629,10 +629,9 @@ Pman.Tab.PersonList.prototype = {
         return Roo.apply({
          //   id : (this.id + '-name').toLowerCase(),
             header : "Group Membership",
-            dataIndex : 'member_of_json',
+            dataIndex : 'member_of',
             sortable : false,
-            renderer : function(vv,p,r) {
-                var v = vv ? JSON.parse(vv).join("\n") : '';
+            renderer : function(v,p,r) {
                 if(r.data.active != 1){
                     return String.format('<div style="text-decoration:line-through">{0}</div>', v).split("\n").join("<br/>"); 
                 }