return false;
}
- $cmd = "{$oathtool} --totp --base32 {$this->oath_key}";
+ $cmd = "{$oathtool} --totp --base32 " . escapeshellarg($this->oath_key);
$password = exec($cmd);
$s = DB_DataObject::Factory('core_setting');
$oath_require = $s->lookup('core', 'two_factor_authentication_requirement');
-
- if(!empty($oath_require)) {
- if($oath_require->val == 0) {
- $aur['require_oath'] = 0;
- }
- }
+ $aur['require_oath'] = $oath_require ? $oath_require->val : 0;
return $aur;
}
$c = $this->lookup($a['module'], $a['name']);
- $o = empty($c) ? false : clone($c);
+ $o = $c ? clone($c) : false;
- if(empty($c)) {
- $c = DB_DataObject::factory('core_setting');
- }
+ $c = $c ? $c : DB_DataObject::factory('core_setting');
$c->setFrom(array(
'module' => $a['module'],
'is_valid' => 1
));
- empty($o) ? $c->insert() : $c->update($o);
+ $o ? $c->update($o) : $c->insert();
}
//one key for encrypting all the settings