From: Steve Hackbarth <stephenhackbarth@gmail.com>
Date: Thu, 18 Sep 2014 18:13:46 +0000 (-0400)
Subject: Merge pull request #1848 from gilmoskowitz/i24559_xtlocks
X-Git-Tag: v4.7.0-beta.2~13
X-Git-Url: http://git.roojs.org/?a=commitdiff_plain;h=e6a05dc5f16794e374ca576e765bac05d7863a8f;hp=6f3e82ba3f1b8ec449de7b2d7154eddb55a0be6b;p=xtuple

Merge pull request #1848 from gilmoskowitz/i24559_xtlocks

issue #24559 - locking with pg 9.3 and web vs qt clients
---

diff --git a/foundation-database/public/tables/metasql/billingSelections-detail.mql b/foundation-database/public/tables/metasql/billingSelections-detail.mql
index 864b03bc2..66bfe7e5c 100644
--- a/foundation-database/public/tables/metasql/billingSelections-detail.mql
+++ b/foundation-database/public/tables/metasql/billingSelections-detail.mql
@@ -1,8 +1,8 @@
 -- Group: billingSelections
 -- Name: detail
 -- Notes: used by dspBillingSelections
--- Copyright (c) 1999-2014 by OpenMFG LLC, d/b/a xTuple.
--- See www.xtuple.com/CPAL for the full text of the software license.
+--        Copyright (c) 1999-2014 by OpenMFG LLC, d/b/a xTuple.
+--        See www.xtuple.com/CPAL for the full text of the software license.
 
 SELECT cobmisc_id, cohead_id,
        cohead_number, cust_number, cust_name,
@@ -21,7 +21,7 @@ FROM cobmisc, cohead, custinfo, coitem, cobill
 WHERE ((cobmisc_cohead_id=cohead_id)
    AND (cohead_cust_id=cust_id)
    AND (coitem_cohead_id=cohead_id)
-   AND (cobill_coitem_id=coitem_id)
+   AND (cobill_coitem_id=coitem_id) AND (COALESCE(cobill_invcnum,0) = 0)
    AND (NOT cobmisc_posted))
 GROUP BY cobmisc_id, cohead_id, cohead_number, cust_number,
          cust_name, cobmisc_misc, cobmisc_freight, cobmisc_tax, cobmisc_payment
diff --git a/foundation-database/public/tables/report/BankrecHistory.xml b/foundation-database/public/tables/report/BankrecHistory.xml
index 8ffe63e0e..151a654e8 100644
--- a/foundation-database/public/tables/report/BankrecHistory.xml
+++ b/foundation-database/public/tables/report/BankrecHistory.xml
@@ -24,7 +24,7 @@
   <name>head</name>
   <sql>SELECT (bankaccnt_name || '-' || bankaccnt_descrip) AS f_bankaccnt,
        (formatDate(bankrec_opendate) || '-' || formatDate(bankrec_enddate)) AS f_bankrec,
-       bankrec_username AS f_username, formatDate(bankrec_created) AS f_created,
+       bankrec_username AS f_username, formatDate(bankrec_postdate) AS f_postdate,
        formatDate(bankrec_opendate) AS f_opendate,
        formatDate(bankrec_enddate) AS f_enddate,
        formatMoney(bankrec_openbal) AS f_openbal,
@@ -218,7 +218,7 @@
    <vcenter/>
    <data>
     <query>head</query>
-    <column>f_created</column>
+    <column>f_postdate</column>
    </data>
   </field>
   <label>
diff --git a/foundation-database/public/trigger_functions/usrpriv.sql b/foundation-database/public/trigger_functions/usrpriv.sql
index 7ab00984e..b35a826d6 100644
--- a/foundation-database/public/trigger_functions/usrpriv.sql
+++ b/foundation-database/public/trigger_functions/usrpriv.sql
@@ -1,4 +1,4 @@
-CREATE OR REPLACE FUNCTION _usrprivTrigger() RETURNS TRIGGER AS $$
+CREATE OR REPLACE FUNCTION _usrprivTrigger() RETURNS TRIGGER AS $$
 -- Copyright (c) 1999-2014 by OpenMFG LLC, d/b/a xTuple. 
 -- See www.xtuple.com/CPAL for the full text of the software license.
 DECLARE
@@ -8,6 +8,13 @@ BEGIN
   -- This looks like a candidate for a foreign key but isn't.
   -- fkeys don't work if the foreign key value resides in a child of the 
   -- table and not the table itself.
+  IF (NOT EXISTS(SELECT usrpriv_id 
+                 FROM usrpriv, priv  
+                 WHERE ((usrpriv_priv_id=priv_id) AND (priv_name ='MaintainUsers')
+                        AND (usrpriv_username=geteffectivextuser())))) THEN
+    RAISE EXCEPTION 'User have no privileges to modify user privileges.';
+  END IF;                
+
   IF ((TG_OP = 'UPDATE' OR TG_OP = 'INSERT') AND
       (NOT EXISTS(SELECT priv_id
                   FROM priv