From: garyhgohoos <gary@xtuple.com>
Date: Thu, 31 Jul 2014 13:55:15 +0000 (-0400)
Subject: Issue #24154:add error checking to coitem trigger
X-Git-Tag: v4.6.0~9^2
X-Git-Url: http://git.roojs.org/?a=commitdiff_plain;h=7b8c001d6256a68de3cb2411f7715fdaa03d8d37;p=xtuple

Issue #24154:add error checking to coitem trigger
---

diff --git a/foundation-database/public/trigger_functions/coitem.sql b/foundation-database/public/trigger_functions/coitem.sql
index 6c78eb884..f920ca771 100644
--- a/foundation-database/public/trigger_functions/coitem.sql
+++ b/foundation-database/public/trigger_functions/coitem.sql
@@ -523,12 +523,14 @@ BEGIN
   IF (TG_OP = 'INSERT') THEN
     -- Create Purchase Request if flagged to do so
     IF ((NEW.coitem_order_type='R') AND (NEW.coitem_order_id=-1)) THEN
-      SELECT createpr(CAST(cohead_number AS INTEGER), 'S', NEW.coitem_id) INTO _orderid
+      SELECT createPR(CAST(cohead_number AS INTEGER), 'S', NEW.coitem_id) INTO _orderid
       FROM cohead
       WHERE (cohead_id=NEW.coitem_cohead_id);
       IF (_orderid > 0) THEN
         UPDATE coitem SET coitem_order_id=_orderid
         WHERE (coitem_id=NEW.coitem_id);
+      ELSE
+        RAISE EXCEPTION 'CreatePR failed, result=%', _orderid;
       END IF;
     END IF;
 
@@ -550,6 +552,8 @@ BEGIN
         IF (_orderid > 0) THEN
           UPDATE coitem SET coitem_order_id=_orderid
           WHERE (coitem_id=NEW.coitem_id);
+        ELSE
+          RAISE EXCEPTION 'CreatePurchaseToSale failed, result=%', _orderid;
         END IF;
       END IF;
     END IF;